amaliujia commented on issue #1453: [CALCITE-3346] Enable some ignored tests in RelOptRuleTests URL: https://github.com/apache/calcite/pull/1453#issuecomment-531996783 To re-enable ignored tests is definitely a good idea. I will spend some time to check how those ignored tests in PR work(I see some changes on tests and not sure if they have changed intentions of original tests). Meanwhile, I am seeing other style fixes in this PR. Maybe it's better to send a hot fix PR to fix those styles than mixing with `CALCITE-3346`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
