yanlin-Lynn commented on a change in pull request #1451: [CALCITE-3334] 
Refinement for Substitution-Based MV Matching
URL: https://github.com/apache/calcite/pull/1451#discussion_r324966239
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
 ##########
 @@ -916,18 +947,22 @@ public RexSimplify getSimplify() {
    * Result of an application of a {@link UnifyRule} indicating that the
    * rule successfully matched {@code query} against {@code target} and
    * generated a {@code result} that is equivalent to {@code query} and
-   * contains {@code target}.
+   * contains {@code target}. {@code triedEnough} indicates whether there's
 
 Review comment:
   how can we know when is enough?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to