jinxing64 opened a new pull request #1461: [CALCITE-3357] Trivial null checking in RelSet#addAbstractConverters URL: https://github.com/apache/calcite/pull/1461 In current code of `RelSet#addAbstractConverters`, null checking of `curRelTrait` happens after clause of assert `curRelTrait.getTraitDef() == traitDef`; It makes more sense to adjust the order; In my understanding, this issue was not found previously for two reasons: `AbstractConverter` is not enabled by default (https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableConvention.java#L65) It rarely happens that two algebra expression operators have identical semantics but different `RelTraitDef` I found this issue when working on https://issues.apache.org/jira/browse/CALCITE-2970
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
