amaliujia commented on a change in pull request #1453: [CALCITE-3346] Enable
some ignored tests in RelOptRuleTests
URL: https://github.com/apache/calcite/pull/1453#discussion_r326342555
##########
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##########
@@ -4715,11 +4733,19 @@ LogicalProject(ENAME=[$1])
</Resource>
<Resource name="planBefore">
<![CDATA[
-ProjectRel(DNAME=[$10], ENAME=[$1])
- FilterRel(condition=[=($10, 'Propane')])
- JoinRel(condition=[=($7, $9)], joinType=[inner])
- TableAccessRel(table=[[CATALOG, SALES, EMP]])
- TableAccessRel(table=[[CATALOG, SALES, DEPT]])
+LogicalProject(DNAME=[$10], ENAME=[$1])
+ LogicalFilter(condition=[=($10, 'Propane')])
+ LogicalJoin(condition=[=($7, $9)], joinType=[inner])
+ LogicalTableScan(table=[[CATALOG, SALES, EMP]])
+ LogicalTableScan(table=[[CATALOG, SALES, DEPT]])
+]]>
+ </Resource>
+ <Resource name="planAfter">
+ <![CDATA[
+LogicalCalc(expr#0..10=[{inputs}], expr#11=[=($t7, $t9)],
expr#12=['Propane':VARCHAR(10)], expr#13=[=($t10, $t12)], expr#14=[AND($t11,
$t13)], DNAME=[$t10], ENAME=[$t1], $condition=[$t14])
+ LogicalJoin(condition=[true], joinType=[inner])
Review comment:
Not sure when this optimization could be useful: it change a inner equi-join
to cross join and move the filter to Calc. So it's doing a filter moving up.
Also need a better to check this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
