hsyuan commented on a change in pull request #1456: [CALCITE-3350] Keep same
with origin type for RexLiteral when deserialized from json string
URL: https://github.com/apache/calcite/pull/1456#discussion_r326427469
##########
File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
##########
@@ -675,15 +661,57 @@
RelJsonWriter jsonWriter = new RelJsonWriter();
relNode.explain(jsonWriter);
final String relJson = jsonWriter.asString();
- String s = deserializeAndDumpToTextFormat(getSchema(relNode), relJson);
+ String s = deserializeAndDumpToTextFormat(getSchema(relNode), relJson,
SqlExplainFormat.TEXT);
Review comment:
The method name already tells us that it is dumping to TEXT format...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
