danny0405 commented on a change in pull request #1460: [CALCITE-3352]
ProjectToWindowRule sets wrong collation on generated Window
URL: https://github.com/apache/calcite/pull/1460#discussion_r326460088
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptTestBase.java
##########
@@ -236,6 +238,7 @@ protected void checkPlanning(Tester tester, HepProgram
preProgram,
}
}
SqlToRelTestBase.assertValid(r);
+ return r;
Review comment:
You should not return `relNode` from this method, you can reference this
code to get a `relNode` with rule fired [1]
[1]
https://github.com/apache/calcite/blob/df3dc81f23166c15e72d5414944c69a35c2bd110/core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java#L311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
