jinxing64 commented on a change in pull request #1451: [CALCITE-3334]
Refinement for Substitution-Based MV Matching
URL: https://github.com/apache/calcite/pull/1451#discussion_r326974018
##########
File path:
core/src/main/java/org/apache/calcite/plan/MaterializedViewSubstitutionVisitor.java
##########
@@ -39,9 +39,9 @@
private static final ImmutableList<UnifyRule> EXTENDED_RULES =
ImmutableList.<UnifyRule>builder()
.addAll(DEFAULT_RULES)
- .add(ProjectToProjectUnifyRule1.INSTANCE)
- .add(FilterToFilterUnifyRule1.INSTANCE)
- .add(FilterToProjectUnifyRule1.INSTANCE)
+// .add(ProjectToProjectUnifyRule1.INSTANCE)
+// .add(FilterToFilterUnifyRule1.INSTANCE)
+// .add(FilterToProjectUnifyRule1.INSTANCE)
Review comment:
Thanks a lot @hsyuan
In current, I'd prefer to commenting out the unused rules. Thus to keep this
patch cleaner and easier for review.
If this patch is approved. I will remove the unused rules instantly.
Thanks again for looking into this and starting the review :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
