yanlin-Lynn commented on a change in pull request #1453: [CALCITE-3346] Enable
some ignored tests in RelOptRuleTests
URL: https://github.com/apache/calcite/pull/1453#discussion_r326992871
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -3670,7 +3659,6 @@ private void transitiveInference(RelOptRule...
extraRules) throws Exception {
transitiveInference();
}
- @Ignore("not working")
@Test public void testTransitiveInferenceUnion3wayOr() throws Exception {
Review comment:
OK, I got your point.
I update the PR, and add the sql as input parameter for
`transitiveInference` method.
I add a check to make sure the sql parameter passed is the same with sql in
`RelOptRules.xml`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services