danny0405 commented on issue #1456: [CALCITE-3350] Keep same with origin type for RexLiteral when deserialized from json string URL: https://github.com/apache/calcite/pull/1456#issuecomment-534087496 @yanlin-Lynn I re-checked the code and believe there is problem in the consistent type logic for `COMPARE`[1], it always returns null. Besides that, i still think this fix is not necessary, `STRING` literal should have a `CHAR(n)` type. [1] https://github.com/apache/calcite/blob/a7a566bb004fd73ee6402652f5572ad0012a97c9/core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java#L797
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
