xndai commented on issue #552: [CALCITE-2018] Queries failed with AssertionError: rel has lower cost… URL: https://github.com/apache/calcite/pull/552#issuecomment-534347114 Based on this change, I made a couple of modifications, now the isValid() check passes for all unit tests. You can find at my changes at - https://github.com/xndai/calcite/tree/2018 The key thing I add is that when a RelNode is renamed and it is subset's best RelNode, we propagate change improvements since the subset's best cost could be changed. I also turn on isValid() check under assert. Also with this change, we run into some CyclicMetadataException when accessing meta. Right now I just catch and ignore, similar to how it is handled in other parts of the code. But in the long run, we will need to figure out better way to handle cyclic. @vvysotskyi @zabetak
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
