julianhyde commented on issue #1453: [CALCITE-3346] Enable some ignored tests in RelOptRuleTests URL: https://github.com/apache/calcite/pull/1453#issuecomment-534763696 The `transitiveInference` method was always a bit weird, and different from other tests. But at least it made things concise. After these changes, adding a `sql` parameter, it is no longer concise. Can we get rid of it, so that the tests look like other tests? Use your judgment to create tests that are readable, clear, maintainable, without too much redundancy.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
