hsyuan commented on a change in pull request #1476: [CALCITE-3374] Error format
check result for explain plan as json
URL: https://github.com/apache/calcite/pull/1476#discussion_r328721197
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlExplain.java
##########
@@ -172,7 +172,7 @@ public boolean isXml() {
* Returns whether result is to be in JSON format.
*/
public boolean isJson() {
- return getFormat() == SqlExplainFormat.XML;
+ return getFormat() == SqlExplainFormat.JSON;
Review comment:
nice catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services