amaliujia commented on issue #1457: [WIP][Prototype][CALCITE-3340] TUMBLE as a TableFunction URL: https://github.com/apache/calcite/pull/1457#issuecomment-535658020 @julianhyde I like your idea. So we save "TUMBLE" for one operator and use a new name for another operator, but Parser will code one so it will create an operator directly without caring about operator name. By doing so operator overloading is also avoided. I like it. You suggest code old TUMBLE into parser(thus rename old TUMBLE operator to maybe "TUMBLE_old"), which seems to me there will be a backward compatible issue: maybe someone is already depending on "TUMBLE" as the name to lookup the old TUMBLE operator? If this is a concern it would be better to use new name for the new operator and code the new operator into Parser. And then we should start a deprecation process at some point to say only maintain old operator for 2 ~ 3 versions, and finally switch the name back. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
