danny0405 commented on issue #552: [CALCITE-2018] Queries failed with 
AssertionError: rel has lower cost…
URL: https://github.com/apache/calcite/pull/552#issuecomment-536144459
 
 
   Thanks @xndai for the additional patch, the `CyclicMetadataException` 
already says that exception is thrown for signaling purposes, so the stack 
trace is not really important. Also i rechecked the code and make sure that the 
fix of @vvysotskyi is the right way to go, we should consider:
   
   1. Propagate the cost when 2 RelSet are merged.
   2. Clear the cached metadata for parents when propagating.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to