hsyuan commented on a change in pull request #1459: [CALCITE-3347]
IndexOutOfBoundsException in FixNullabilityShuttle when using FilterIntoJoinRule
URL: https://github.com/apache/calcite/pull/1459#discussion_r330722953
##########
File path: core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java
##########
@@ -329,7 +330,17 @@ protected void validateJoinFilters(List<RexNode>
aboveFilters,
final Iterator<RexNode> filterIter = joinFilters.iterator();
while (filterIter.hasNext()) {
RexNode exp = filterIter.next();
- if (!predicate.apply(join, joinType, exp)) {
+ int maxIndex = -1;
+ ImmutableList<RexInputRef> inputRefs = RexUtil.getAllInputRef(exp);
+ for (RexInputRef rexInputRef: inputRefs) {
+ if (rexInputRef.getIndex() > maxIndex) {
+ maxIndex = rexInputRef.getIndex();
+ }
+ }
+ // For case of semi join, the max index may bigger than field count,
+ // then, the filter condition should not be added to {@code
aboveFilters}.
+ // Otherwise, it may cause IndexOutOfBoundsException later.
Review comment:
Change the comment to
```
Do not pull up filter conditions if the max index
is greater than the join field count.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
