yanlin-Lynn commented on issue #1459: [CALCITE-3347] IndexOutOfBoundsException 
in FixNullabilityShuttle when using FilterIntoJoinRule
URL: https://github.com/apache/calcite/pull/1459#issuecomment-537915967
 
 
   Since update predicate has the risk of changing the public API, and, 
predicate `NOT_ENUMERABLE` is marked to be removed before 1.22.0.
   How about update like this
   ```
   if (!predicate.apply(join, joinType, exp) && joinType.projectsRight()) {
           aboveFilters.add(exp);
           filterIter.remove();
         }
   ```
   as @jinxing64  suggested.
   I'm OK with chcking index or checking project right.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to