hsyuan commented on a change in pull request #1383: [CALCITE-3254] Exception
while deserializing of interval type or with empty partition/order key for
RexOver
URL: https://github.com/apache/calcite/pull/1383#discussion_r331183069
##########
File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java
##########
@@ -475,8 +488,10 @@ RexNode toRex(RelInput relInput, Object o) {
physical = false;
}
final boolean distinct = (Boolean) map.get("distinct");
- return rexBuilder.makeOver(type, operator, rexOperands,
partitionKeys,
- ImmutableList.copyOf(orderKeys), lowerBound, upperBound,
physical,
+ return rexBuilder.makeOver(type, operator, rexOperands,
+ ImmutableList.copyOf(partitionKeys),
+ ImmutableList.copyOf(orderKeys),
Review comment:
You don't need to make a immutable copy, the RexWindow constructor make do
it. orderKeys has it because of improper API definition, I guess.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
