jinxing64 commented on issue #1451: [CALCITE-3334] Refinement for Substitution-Based MV Matching URL: https://github.com/apache/calcite/pull/1451#issuecomment-540497546 After the rules added in this patch, all rules in `MaterializedViewSubstitutionVisitor` can retire except `UnionToUnionUnifyRule`. I move `UnionToUnionUnifyRule` to SubstituionVisitor.java and all materialization matching work/ability is on `SubstitutionVisitor` in current code. Gentle PING @julianhyde @amoghmargoor @maryannxue , is it ok to remove `MaterializedViewSubstitutionVisitor` ? It's great to get some feedbacks from you experts when you have time :) Thanks a lot ~~
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
