jinxing64 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM 
expression to SqlKind and include it in the p…
URL: https://github.com/apache/calcite/pull/1492#discussion_r333973587
 
 

 ##########
 File path: 
mongodb/src/main/java/org/apache/calcite/adapter/mongodb/MongoFilter.java
 ##########
 @@ -216,6 +216,7 @@ private boolean translateBinary2(String op, RexNode left, 
RexNode right) {
       case CAST:
         return translateBinary2(op, ((RexCall) left).operands.get(0), right);
       case OTHER_FUNCTION:
 
 Review comment:
   Shall we just remove this line-218 ? Since `MongoRules.isItem` indicates 
that it only works for `ITEM`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to