danny0405 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM
expression to SqlKind and include it in the p…
URL: https://github.com/apache/calcite/pull/1492#discussion_r334215196
##########
File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java
##########
@@ -624,6 +624,13 @@ private RexProgramBuilder createProg(int variant) {
case_(isNotNull(i0), i0, i1), c01),
is(true));
+ final RelDataType intArray = typeFactory.createArrayType(intType, -1);
+ RexInputRef inputRef = rexBuilder.makeInputRef(intArray, 0);
+ RexNode rexNode = rexBuilder.makeCall(
+ SqlStdOperatorTable.ITEM,
+ inputRef,
+ rexBuilder.makeLiteral(0, intType, false));
Review comment:
Can we also add some test cases in `#simplifyStrong` ? Also, you can create
a tool method to create the item call, just like `plus(` and `sub(`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
