yanlin-Lynn commented on a change in pull request #1496: [CALCITE-3400] Add 
support for interpretering left/right/semi/anti/full join
URL: https://github.com/apache/calcite/pull/1496#discussion_r334229532
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/interpreter/AggregateNode.java
 ##########
 @@ -536,6 +539,29 @@ public MinDouble() {
     }
   }
 
+  /** Implementation of {@code MIN} function to calculate the minimum of
+   * {@code boolean} values as a user-defined aggregate.
+   */
+  public static class MinBoolean {
 
 Review comment:
   For anti join, right input of the join may like this,
   ```
   LogicalAggregate(group=[{0}], agg#0=[MIN($1)])
       LogicalProject(X=[$0], $f1=[true])
           LogicalValues(tuples=[[{ 1, 'd' }]])
   ```
   
   so need to calculate the minimum of boolean values, use MinBoolean as a 
user-defined aggregate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to