amansinha100 commented on a change in pull request #1492: [CALCITE-3390] Add
ITEM expression to SqlKind and include it in the p…
URL: https://github.com/apache/calcite/pull/1492#discussion_r334617962
##########
File path:
geode/src/main/java/org/apache/calcite/adapter/geode/rel/GeodeFilter.java
##########
@@ -167,6 +167,7 @@ private String getLeftNodeFieldName(RexNode left) {
// FIXME This will not work in all cases (for example, we ignore
string encoding)
return getLeftNodeFieldName(((RexCall) left).operands.get(0));
case OTHER_FUNCTION:
+ case ITEM:
return left.accept(new
GeodeRules.RexToGeodeTranslator(this.fieldNames));
Review comment:
Is that for performance reasons ? The JIT compiler should do a decent job
of optimizing the switch-case for the more frequently occurring condition
(assuming there's sufficient warm-up).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
