yanlin-Lynn commented on a change in pull request #1504: [CALCITE-3409] Add an
interface in MaterializedViewSubstitutionVisito…
URL: https://github.com/apache/calcite/pull/1504#discussion_r334732347
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -311,6 +314,10 @@ public RelNode getRoot() {
return ImmutableList.copyOf(materializations);
}
+ @Override public void registerMaterializationRules(List<UnifyRule> rules) {
+ materializationRules = rules;
Review comment:
how about make `materializationRules` immutable, and use
`ImmutableList.copyOf` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
