soma-mondal commented on a change in pull request #1437: [CALCITE-3318]
Preserving CAST of STRING operands in comparison operator
URL: https://github.com/apache/calcite/pull/1437#discussion_r335340046
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlDialect.java
##########
@@ -984,6 +987,20 @@ public boolean supportsAliasedValues() {
return true;
}
+ /**
+ * Returns whether the dialect needs cast in string operands of comparison
operator. For instance,
+ * where employee_id = '10' is comparable in most of the dialect, so doesn't
need cast for string
+ * operand '10'. But in BiqQuery the above statement is not valid without
cast.
+ * @param node Operand of comparison operator which contain cast.
Review comment:
Thank for pointing out, will update the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
