xndai commented on a change in pull request #1354: [CALCITE-482] Implement sql
and planner hints
URL: https://github.com/apache/calcite/pull/1354#discussion_r335565680
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Join.java
##########
@@ -52,11 +55,12 @@
* The set of output rows is a subset of the cartesian product of the two
* inputs; precisely which subset depends on the join condition.
*/
-public abstract class Join extends BiRel {
+public abstract class Join extends BiRel implements RelWithHint {
Review comment:
It also hurts debugability when hints are not included in the digest -
there's no way to tell if a relnode has hint associated by just looking at the
generated plan. There are both pros and cons. I agree we need more thinkings on
this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
