hsyuan commented on a change in pull request #1354: [CALCITE-482] Implement sql 
and planner hints
URL: https://github.com/apache/calcite/pull/1354#discussion_r335786681
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java
 ##########
 @@ -88,6 +89,7 @@ protected VolcanoRuleCall(
 
   // implement RelOptRuleCall
   public void transformTo(RelNode rel, Map<RelNode, RelNode> equiv) {
+    rel = RelOptUtil.copyRelHints(rels[0], rel);
 
 Review comment:
   In `FilterJoinRule`, if we have a hint called selectivity, after the filter 
is pushed into join inputs, you will copy selectivity hint to Join node, which 
is undesired. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to