danny0405 commented on a change in pull request #1510: [CALCITE-3418] Grouped
Window Function TUMBLE should return "$TUMBLE"…
URL: https://github.com/apache/calcite/pull/1510#discussion_r335843185
##########
File path:
core/src/main/java/org/apache/calcite/sql/SqlGroupedWindowFunction.java
##########
@@ -128,13 +128,6 @@ public SqlGroupedWindowFunction auxiliary(String name,
SqlKind kind) {
// make the method abstract.
return call.getOperandMonotonicity(0).unstrict();
}
-
- @Override public String getName() {
- // Always rename the name of the SqlKind. The tumble operator is called
- // "$TUMBLE", so that it does not clash with a user-defined table function
- // "TUMBLE", but we want the name to be "TUMBLE".
- return getKind().name();
- }
Review comment:
Did you notice what the comment wants to state ? It says that although it's
operator name is "$TUMBLE" but we still want to rename it to "TUMBLE" because
this name is what we use in the SQL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
