danny0405 commented on a change in pull request #1519: [CALCITE-3424]
AssertionError thrown for user-defined table function with array argument
URL: https://github.com/apache/calcite/pull/1519#discussion_r336421413
##########
File path: core/src/test/java/org/apache/calcite/util/Smalls.java
##########
@@ -182,6 +184,10 @@ public void close() {
};
}
+ public static QueryableTable generateStrings2(final List<Integer> list) {
+ return generateStrings(list.size());
Review comment:
Can we give it a more meaning name ? not XXX2 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
