yanlin-Lynn commented on a change in pull request #1519: [CALCITE-3424]
AssertionError thrown for user-defined table function with array argument
URL: https://github.com/apache/calcite/pull/1519#discussion_r336467294
##########
File path: core/src/main/java/org/apache/calcite/jdbc/JavaTypeFactoryImpl.java
##########
@@ -251,13 +253,25 @@ public static RelDataType toSql(final RelDataTypeFactory
typeFactory,
type.getFieldNames()),
type.isNullable());
} else if (type instanceof JavaType) {
- return typeFactory.createTypeWithNullability(
- typeFactory.createSqlType(type.getSqlTypeName()),
- type.isNullable());
+ Class javaClass = ((JavaType) type).getJavaClass();
+ final RelDataType nonNullType;
+ if (javaClass.isArray()) {
Review comment:
I'm not sure that's a bug or is just designed.
I create a PR(https://github.com/apache/calcite/pull/1521) trying to fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
