danny0405 commented on a change in pull request #1521: [CALCITE-3429]
Refinement for implementation of sql type factory
URL: https://github.com/apache/calcite/pull/1521#discussion_r336719107
##########
File path:
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactoryImpl.java
##########
@@ -612,8 +612,15 @@ public SqlCollation getCollation() {
}
public SqlTypeName getSqlTypeName() {
+ Class clz = clazz;
+ if (List.class.isAssignableFrom(clazz) ||
java.sql.Array.class.isAssignableFrom(clazz)
+ || java.lang.reflect.Array.class.isAssignableFrom(clazz)) {
+ clz = List.class;
+ } else if (Map.class.isAssignableFrom(clazz)) {
+ clz = Map.class;
+ }
final SqlTypeName typeName =
- JavaToSqlTypeConversionRules.instance().lookup(clazz);
+ JavaToSqlTypeConversionRules.instance().lookup(clz);
Review comment:
Only `Map` is enough, in `JavaToSqlTypeConversionRules` we already have List
and Array
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
