jinxing64 commented on a change in pull request #1520: [CALCITE-3428] Refine RelMdColumnUniqueness for Filter by considering… URL: https://github.com/apache/calcite/pull/1520#discussion_r336762602
########## File path: core/src/test/resources/sql/sub-query.iq ########## @@ -621,10 +621,11 @@ where exists ( (1 row) !ok Review comment: Q: Why this change ? A: `ename` is key column of `emp`. Thus no `Aggregate` is generated for the right-hand side of `Join`. Thus `SemiJoinRule` fails generate a semi-join for this Sql. Since this test (CALCITE-1494) targets to verify `"More efficient plan for correlated sub-queries, omitting value-generating scans where possible"`, I think this change doesn't break the original testing purpose/intention. I filed another JIRA https://issues.apache.org/jira/browse/CALCITE-3431 to track this issue and will work on it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
