danny0405 commented on a change in pull request #1414: [CALCITE-3293] Add
strcmp function
URL: https://github.com/apache/calcite/pull/1414#discussion_r336822585
##########
File path: core/src/test/java/org/apache/calcite/test/SqlFunctionsTest.java
##########
@@ -79,6 +80,12 @@
assertEquals("nullb", concat(null, "b"));
}
+ @Test public void testStrcmp() {
+ assert -1 == strcmp("text", "text2");
+ assert 1 == strcmp("text2", "text");
+ assert 0 == strcmp("text", "text");
Review comment:
Can we also add some negative tests ? The invalid arguments and
`binary/varbinary` type arguments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
