hsyuan commented on a change in pull request #1451: [CALCITE-3334] Refinement
for Substitution-Based MV Matching
URL: https://github.com/apache/calcite/pull/1451#discussion_r337284075
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -159,6 +169,9 @@
* Assumes no rule needs more than 2 slots. */
protected final MutableRel[] slots = new MutableRel[2];
+ // FOR TESTING.
+ public static boolean disabled = false;
Review comment:
Double negative is counter intuitive, can we give it `enabled = true`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
