danny0405 commented on issue #1354: [CALCITE-482] Implement sql and planner hints URL: https://github.com/apache/calcite/pull/1354#issuecomment-544793346 > * I saw you are supporting `WITH` hint. I am against on supporting it. 1 single style `/*+ */` would suffice. > * `RelWithHint` gives me impression that it is still a RelNode class. `Hintable` or `IHint` or other name may be better? Similarly, `RelHint` is a relational node? But it is not. `HintNode` might be better? - The `WITH` has already been removed based on Julian's comments. - `RelWithHint` means a relational node with hint, the sub-class of it are exactly all relational nodes; for `RelHint` it has a sql node counter-part named `SqlHint`, `RelHint` means hint of a `RelNode`, i do not think the name is ambiguous
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
