danny0405 commented on a change in pull request #1507: [CALCITE-3414] In
calcite-core, use RexToLixTranslator.convert for type conversion code
generation uniformly
URL: https://github.com/apache/calcite/pull/1507#discussion_r337499185
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java
##########
@@ -1143,14 +1156,20 @@ public static Expression convert(Expression operand,
Type fromType,
"toString",
operand));
} else {
- // E.g. from "BigDecimal" to "String"
- // Generate "x == null ? null : x.toString()"
- return Expressions.condition(
- Expressions.equal(operand, RexImpTable.NULL_EXPR),
- RexImpTable.NULL_EXPR,
- Expressions.call(
- operand,
- "toString"));
+ Expression result;
+ try {
+ // Try to call "toString()" method
+ // E.g. from "Integer" to "String"
+ // Generate "x == null ? null : x.toString()"
+ result = Expressions.condition(
+ Expressions.equal(operand, RexImpTable.NULL_EXPR),
+ RexImpTable.NULL_EXPR,
+ Expressions.call(operand, "toString"));
+ } catch (Exception e) {
+ // No "toString()" method, fall through to (String)x
Review comment:
I'm not sure how this code works, compared to this code, i'm more inclined
with the try catch way, do we need to refine the specific exception instead of
just `Exception` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
