hsyuan commented on a change in pull request #1451: [CALCITE-3334] Refinement
for Substitution-Based MV Matching
URL: https://github.com/apache/calcite/pull/1451#discussion_r338846126
##########
File path: core/src/test/java/org/apache/calcite/test/MaterializationTest.java
##########
@@ -126,6 +126,13 @@
new RexSimplify(rexBuilder, RelOptPredicateList.EMPTY, RexUtil.EXECUTOR)
.withParanoid(true);
+ private final String deduplicatedEmps =
+ "(select distinct \"empid\", \"deptno\", \"name\", \"salary\",
\"commission\"\n"
+ + "from \"emps\") \"dedupEmps\"";
+ private final String deduplicatedDepts =
+ "(select distinct \"deptno\", \"name\"\n"
+ + "from \"depts\") \"dedupDepts\"";
Review comment:
Although it make duplicate query string less, it will make us hard to read.
We have to scroll up to see what exactly the subquery is. I would recommend
inlining them, and remove these 2 variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
