amaliujia commented on a change in pull request #1544: [CALCITE-3415] Supports
REGEXP_SUBSTR function
URL: https://github.com/apache/calcite/pull/1544#discussion_r340755290
##########
File path:
core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java
##########
@@ -142,6 +149,9 @@ public BigQuerySqlDialect(SqlDialect.Context context) {
SqlSyntax.BINARY.unparse(writer, INTERSECT_DISTINCT, call, leftPrec,
rightPrec);
}
break;
+ case REGEXP_SUBSTR:
Review comment:
A Sqlkind is not needed for REGEXP_SUBSTR. The `unparse` should go
`super.unparseCall(writer, call, leftPrec, rightPrec);`, in which it will
require you to implement `unparse` for your new operators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
