asereda-gs commented on issue #1518: [CALCITE-3434]ElasticSearch schema with 
pathPrefix
URL: https://github.com/apache/calcite/pull/1518#issuecomment-548173237
 
 
   There are two ways to go about `pathPrefix` configuration:
   1. Since [CALCITE-3335](https://issues.apache.org/jira/browse/CALCITE-3335) 
elastic accepts configuration as list of URLs:
   ```json
   { "hosts": ["http://localhost:1234";, "http://localhost:8080";] }
   ```
   Theoretically one can provide pathPrefix as part of `hosts` array:
   ```json
   { "hosts": ["http://localhost:1234/myPrefix";] }
   ```
   The issue is that `pathPrefix` should be unique across all hosts and it is 
easy to miss it for many hosts. 
   
   2. Have separate JSON parameter `pathPrefix` as proposed in this PR
   
   I think (2) is better and more intuitive. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to