hsyuan commented on a change in pull request #1546: [CALCITE-3458] Remove desc
in AbstractRelNode
URL: https://github.com/apache/calcite/pull/1546#discussion_r340955735
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleMatch.java
##########
@@ -144,7 +144,10 @@ private String computeDigest() {
if (i > 0) {
buf.append(", ");
}
- buf.append(rels[i].toString());
+ // Same with {@link rel#getDescription()}, we don't call it explicitly
+ // in order to avoid string copy when generating description.
+ buf.append("rel#").append(rels[i].getId())
+ .append(':').append(rels[i].getDigest());
Review comment:
Sounds good. I have addressed your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
