F21 edited a comment on issue #104: CALCITE-3158: Avatica: migrate build system 
to Gradle
URL: https://github.com/apache/calcite-avatica/pull/104#issuecomment-551299703
 
 
   > What if the script takes certain properties from 
$HOME/.gradle/gradle.properties?
   
   I am not sure how easily this can be mounted into a docker container via 
docker-compose as `$HOME` is an environment variable. We also need to contend 
with Windows machines.
   
   > I do not think it would be great to type the same asfCommitterId again and 
again in the "interactive" mode.
   I haven't found this to be an issue when making the last couple of releases 
for Avatica. I've found the interactive mode to be easier as the script asks 
for everything up front (the asf username, etc is only asked once and then used 
when it's required within a given task) and then everything else is automated. 
The releases has been smoother and less error-prone from past experience.
   
   > The release "with Docker" requires significant preparations (gpg install, 
copy keyring, etc, etc).
   It could probably make sense to add a Dockerfile with gpg installed so one 
could just run a simple command and get suitable environment for the release / 
verification.
   
   This is all automated in `docker.sh`, so it hasn't really been a problem in 
my experience.
   
   Edit: Also, this is not to say that the docker release process should be the 
default. We can definitely go mirror the current approach where there is the 
option to release using either maven, etc installed directly on the machine or 
with docker-compose.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to