hsyuan commented on a change in pull request #1569: [CALCITE-3487] Should not
hard code RelMetadataQuery class in Volcano…
URL: https://github.com/apache/calcite/pull/1569#discussion_r344313195
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptCluster.java
##########
@@ -177,6 +177,14 @@ public void setMetadataQuery(Supplier<RelMetadataQuery>
mqSupplier) {
return (M) mq;
}
+ /**
+ * Returns the RelMetadataQuery supplier
+ * @return The supplier of RelMetadataQuery
+ */
+ public Supplier<RelMetadataQuery> getMetadataQuerySupplier() {
+ return this.mqSupplier;
+ }
+
Review comment:
I am wondering if we should change `setMetadataQuery` to
`setMetadataQuerySupplier` before this version is released out. Because
`setMetadataQuery` is not paired with `getMetadataQuery `, but paired with
`getMetadataQuerySupplier`, which may confuse people.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
