danny0405 commented on a change in pull request #1568:
[CALCITE-3486]MysqlSqlDialect unparse ROW keyword does not exist
URL: https://github.com/apache/calcite/pull/1568#discussion_r344468498
##########
File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java
##########
@@ -3699,6 +3700,13 @@ void checkPeriodPredicate(Checker checker) {
.ok(expected);
}
+ @Test public void testInsertWithRowDialect() {
+ final String expected = "INSERT INTO `emps`\n"
Review comment:
Maybe we can rename this method to `testRowValueExpression` and we should
test dialect that allows/not allow explicit `ROW` keywords.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
