quxiucheng commented on a change in pull request #1568: [CALCITE-3486] In JDBC
adapter, when generating ROW value expression, generates the ROW keyword only
if the dialect allows it (quxiucheng)
URL: https://github.com/apache/calcite/pull/1568#discussion_r344546878
##########
File path:
core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java
##########
@@ -179,6 +179,9 @@ public boolean supportsAliasedValues() {
unparseFloor(writer, call);
break;
+ case ROW:
+ unparseRow(writer, call);
Review comment:
I see.Thanks.
I have a question:
the method `SqlConformanceEnum#allowExplicitRowValueConstructor`
```
public boolean allowExplicitRowValueConstructor() {
switch (this) {
case DEFAULT:
case LENIENT:
return true;
default:
return false;
}
}
```
Only `SqlConformanceEnum#DEFAULT` and `SqlConformanceEnum#LENIENT` return
values are true.
If this standard doesn't change. Test classes are mostly used by default
method `SqlConformanceEnum#PRAGMATIC_99`,
`unparse` will then have a lot of `ROW` keyword changes. Because they don't
support the `ROW` keyword.
Should I add `SqlConformanceEnum#PRAGMATIC_99` to a method
`SqlConformanceEnum#allowExplicitRowValueConstructor` or change the test class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
