hsyuan commented on a change in pull request #1586: [CALCITE-3491]
VolcanoPlanner.completeConversion() is bypassed by "if…
URL: https://github.com/apache/calcite/pull/1586#discussion_r346569044
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -1054,10 +1053,6 @@ private RelNode changeTraitsUsingConverters(
allowInfiniteCostConverters);
if (rel != null) {
assert rel.getTraitSet().getTrait(traitDef).satisfies(toTrait);
- rel =
- completeConversion(
- rel, allowInfiniteCostConverters, toTraits,
- Expressions.list(traitDef));
if (rel != null) {
register(rel, converted);
}
Review comment:
https://github.com/apache/calcite/pull/1586/files#diff-70d5035797baebe157bab8cbf860e456R1061
can be changed to `else if` and remove `rel == null` check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
