danny0405 commented on a change in pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled URL: https://github.com/apache/calcite/pull/1584#discussion_r346616585
########## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java ########## @@ -877,6 +877,10 @@ public RelSubset ensureRegistered(RelNode rel, RelNode equivRel) { * Checks internal consistency. */ protected boolean isValid(Litmus litmus) { + if (this.getRoot() == null) { + return true; Review comment: BTW, next time we fix the code, can we try to give some tests ? Without the test, no one can make sure how the code works and why it should be fixed like that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services