amaliujia commented on a change in pull request #1589: [CALCITE-3508]
Strengthen outer Join to inner if it is under a Filter that discards null values
URL: https://github.com/apache/calcite/pull/1589#discussion_r347180197
##########
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##########
@@ -5397,22 +5397,25 @@ where d.deptno > 7 and e.deptno > 9]]>
<Resource name="planBefore">
<![CDATA[
LogicalProject(EXPR$0=[1])
- LogicalFilter(condition=[>($16, 9)])
Review comment:
Ok, maybe I have thought too much. It depends on how underlying engines
implement it but at least such outer join removal and change to inner join has
no harm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
