julianhyde commented on a change in pull request #1594: [CALCITE-3514]
LatticeTest fails when JdbcSchema re-computes JdbcTables
URL: https://github.com/apache/calcite/pull/1594#discussion_r347564619
##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcTable.java
##########
@@ -200,6 +200,24 @@ public RelNode toRel(RelOptTable.ToRelContext context,
sourceExpressionList, flattened);
}
+ @Override public boolean equals(Object obj) {
Review comment:
I disagree. Two tables are identical if they have the same name, schema etc.
No need to check columns.
The "equals" contract does not say you have to check every field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
