XuQianJin-Stars commented on issue #1591: [CALCITE-3510] Implement sqlquery for Redis adapter URL: https://github.com/apache/calcite/pull/1591#issuecomment-555576843 > @XuQianJin-Stars I left a couple comments and I hope you don't mind, but I rewrote some of the documentation for grammar and clarity. I don't think this needs to be done in this PR, but it looks like for both `csv` and `json`, the `mapping` parameter for each column could be optionally eliminated. For `csv`, the default would be the position in the mapping array and for `json`, the default would be the `json` key. @michaelmior Thank you very much, I like it .
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
