danny0405 commented on a change in pull request #1600: [CALCITE-3527] Enrich
tests for sql hints.
URL: https://github.com/apache/calcite/pull/1600#discussion_r349034988
##########
File path:
core/src/test/java/org/apache/calcite/test/SqlHintsConverterTest.java
##########
@@ -112,12 +113,14 @@ protected DiffRepository getDiffRepos() {
sql(sql).ok();
}
- @Test public void testInvalidQueryHint() {
+ @Test public void testInvalidQueryHint1() {
final String sql = "select /*+ weird_hint */ empno\n"
Review comment:
Thanks for the refactoring, can we give the test cases more meaningful names
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
