vlsi commented on a change in pull request #1375:
[WIP][CALCITE-3140][CALCITE-3141] Failures in slow tests & CI
URL: https://github.com/apache/calcite/pull/1375#discussion_r349284885
##########
File path:
core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java
##########
@@ -5921,7 +5942,16 @@ private void checkNullOperand(SqlTester tester, String
op) {
tester.checkString("CURRENT_CATALOG", "", "VARCHAR(2000) NOT NULL");
}
- @Test public void testLocalTimeFunc() {
+ @Tag("slow")
Review comment:
As you might know, `core/src/test` contains two types of code:
1) Test code. That is `unit tests` or `@Test` methods. This is OK for the
code that tests `core`
2) "test framework" code like `CalciteAssert` which is even reused in other
modules. Dependency on `-tests.jar` is not that right (currently you can
recognize it as dependency on `project(":core", "testClasses")`. For instance,
`-tests.jar` do not have their own pom files. I suggest we factor
`CalciteAssert`-like test framework code into its own module, and use it as a
[test
fixture](https://docs.gradle.org/current/userguide/java_testing.html#sec:java_test_fixtures)
Then we could drop `-tests.jar` generation, as test code adds nothing from
Maven Central perspective.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
